This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
Fix therubyrhino deprecation warnings introduced between 1.73.0 and 1.73.1 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josh or @sstephenson any word on this? |
| s.add_development_dependency "rake" | ||
| s.add_development_dependency "therubyracer" |
There was a problem hiding this comment.
Sorry I can't pull any changes to the gemspec.
|
Is this going to be backwards compatible? |
|
No this is not backwards compatible. therubyrhino seems to have gone through a few more api breaking changes recently as well so this patch would need to be changed to update to the latest anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rubyjs/therubyrhino#11 for details.